[ 
https://issues.apache.org/jira/browse/DBCP-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12935857#action_12935857
 ] 

Phil Steitz commented on DBCP-348:
----------------------------------

Thanks for the patch!

Fixed in r1039158 in the 1.4.x branch and trunk (2.0).  I added a note to the 
current config docs pointing out the problem.

Leaving open until 1.3.1/1.4.1 are released, at which time the config note 
needs to be removed from configuration.xml.

Technically, this is an incompatible change; but I see it as an API bug that 
makes the 1.3/1.4 API unusable without looking at the internals, so the formal 
compatibility break is warranted in 1.3.1/1.4.1

> connectionInitSqls doesn't work correctly. 
> -------------------------------------------
>
>                 Key: DBCP-348
>                 URL: https://issues.apache.org/jira/browse/DBCP-348
>             Project: Commons Dbcp
>          Issue Type: Bug
>    Affects Versions: 1.3, 1.4
>         Environment: CentOS 5.4
> JDK 6u21
>            Reporter: Eiji Takahashi
>            Priority: Minor
>         Attachments: connectionInitSqls.patch
>
>
> The parameter name is different between the source code and the online 
> document.
> Souce code(BasicDataSourceFactory.java):
>    private final static String PROP_INITCONNECTIONSQLS = "initConnectionSqls";
> Online document(http://commons.apache.org/dbcp/configuration.html):
>    Parameter name: connectionInitSqls

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to