garydgregory commented on PR #923: URL: https://github.com/apache/commons-io/pull/923#issuecomment-6604738828
Closing in favor of PR #924. The PR here has the following shortcomings and it's not worth going round and round the "simpleqt" AI until everything is just right. The method implementation can be simpler. This PR does not test several relevant cases: empty streams with nonzero offsets, bounded slices, and mark/reset around oversized skips. These matter because correcting the return value alone does not establish that stream positioning and subsequent reads remain correct. You are credited in `changes.xml`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
