garydgregory commented on PR #112: URL: https://github.com/apache/commons-secure-xml/pull/112#issuecomment-6721165906
Setting to draft. Tests are grossly inadequate: They add useful DOM/SAX and stylesheet warning assertions, but lack direct coverage for StAX reporting, schema/validator reporting, runtime transformer listener wiring, reset behavior, and throwing callbacks. StAX warning delivery stops after installing a resolver: The implementation appears broken or incomplete (see comment). But how knows what this PR really intends since there are so many missing tests. Callback lifecycle handling is incomplete. Applications whose warning callbacks throw can now fail where processing previously completed silently. This behavior needs explicit documentation and tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
