garydgregory opened a new pull request, #755: URL: https://github.com/apache/commons-collections/pull/755
Fix regressions introduced by the chain-flattening optimization in #628, released in 4.6.0. Copying a child chain's iterator queue discarded its active iterator after hasNext() or next(), bypassed subclass overrides, and omitted iterators subsequently added to the child. Retain child iterators instead of copying their contents. Traverse exact IteratorChain instances iteratively, including chains wrapped by UnmodifiableIterator, to avoid stack overflow with deep nesting. Delegate normally to subclasses so their iterator methods and protected updateCurrentIterator() hook remain effective. Preserve locking, cached availability, and removal state throughout nested chains. Keep unmodifiable boundaries intact and clear removal state only after the underlying remove() succeeds. Later additions remain visible until the child chain is visited and locked. Correct the addIterator() exception documentation, document live child behavior and queue-based size() semantics, and update the release notes. Extend regression coverage for partial consumption, repeated lookahead, empty children, exhaustion, null elements, constructor and factory paths, shared sources, subclass overrides, exception recovery, and removal. Verify ordinary and unmodifiable chains nested 20,000 levels deep. This restores live delegation semantics at the cost of traversal work proportional to nesting depth, rather than flattening away child identity. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request: OpenAI Codex. - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
