hutiefang76 opened a new pull request, #418: URL: https://github.com/apache/commons-dbutils/pull/418
The wrapper tests use an always-null ResultSet fixture, leaving non-null values and transitions between rows untested. Add three tests using the shared two-row fixture and a three-row control: values by index and name, `wasNull()` reset, and custom NULL replacements preserving real zero, false and empty-string values. Addresses [DBUTILS-86](https://issues.apache.org/jira/browse/DBUTILS-86). Validation on JDK 21 / Java 11 target: - `SqlNullCheckedResultSetTest`: 47 tests pass. - Default `mvn -B -ntp`: BUILD SUCCESS; all 526 tests pass, no skips. - An isolated mutation that substitutes defaults for every getter leaves the 42 prior declared wrapper tests passing and fails all 3 new tests. The original implementation passes the new tests. The mutation was run outside the repository and is not part of this PR. - [x] Read the contribution guidelines. - [x] Read the ASF Generative Tooling Guidance. - [x] AI was used: DeepSeek assisted the source investigation, tests and first-pass review. Codex corrected fixture assumptions and assertions, reviewed the patch, ran validation and prepared this description. The commit includes Assisted-By trailers; no human review is claimed. - [x] Run a successful build using the default Maven goal. - [x] Add behavioral coverage for the existing issue. This is a test coverage change; the current production implementation passes it. - [x] Describe the change and validation. - [x] Use a meaningful commit message containing the existing Jira key. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
