hutiefang76 opened a new pull request, #302:
URL: https://github.com/apache/commons-jxpath/pull/302
`JXPathContext.getValue("'' = 0")` and the reverse comparison currently
return true, although `number('')` already returns NaN.
`InfoSetUtil.doubleValue` treats an empty string as zero before reaching the
shared number parser.
Route empty strings through that parser, following the [XPath 1.0 number
conversion
rules](https://www.w3.org/TR/1999/REC-xpath-19991116/#section-Number-Functions).
Keep the existing Java-null-to-zero behavior with an explicit null guard. The
existing `JXPath151Test` map-value expectations remain unchanged.
The new tests cover numeric equality and relational comparisons in both
operand orders, arithmetic, floor/ceiling/round, and valid numeric and string
controls. On original production, the focused suite has two failures (`'' = 0`
and `'' + 1`); all nine focused cases pass with the patch.
Validation:
- Complete default Maven goals on Microsoft JDK 21.0.10, with effective
source/target 1.8 and release 8: 418 tests, 417 passed, one existing skip, zero
failures/errors. The configured quality checks and Javadoc generation also
passed.
- The same six public API checks passed on actual Java 8 and Java 21
runtimes.
Fixes [JXPATH-197](https://issues.apache.org/jira/browse/JXPATH-197).
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
https://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for your contribution to [Apache
Commons](https://commons.apache.org/)! Your help is appreciated!
Before you push a pull request, review this list:
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [x] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [x] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute?
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
AI assistance: DeepSeek Pro drafted the implementation/tests and reviewed
the patch. OpenAI Codex refined the regression coverage and formatting,
identified the null compatibility regression in the full build, and ran the
native validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]