dxbjavid opened a new pull request, #793:
URL: https://github.com/apache/commons-text/pull/793

   `RandomStringGenerator` keeps a reference to the `Builder`'s filter set 
instead of copying it, and `Builder.filteredBy(...)` clears and refills that 
same set. So reusing a builder quietly changes generators that were already 
built from it:
   
   ```java
   RandomStringGenerator.Builder builder = 
RandomStringGenerator.builder().withinRange('0', 'z');
   RandomStringGenerator password = 
builder.filteredBy(CharacterPredicates.LETTERS, 
CharacterPredicates.DIGITS).get();
   builder.filteredBy(CharacterPredicates.DIGITS).get();
   password.generate(12); // now digits only
   ```
   
   For a password or token generator that is a silent drop in entropy (12 
characters go from roughly 71 bits to 40). It also means a generator documented 
as thread-safe iterates a set the builder can still modify. The character list 
is already copied in the same constructor, so the predicates are now copied the 
same way.
   
   `testChangeOfFilterAfterGet` fails without the main change (`expected: <a> 
but was: <b>`) and passes with it. The default `mvn` build is green locally on 
Java 21 (1990 tests, Checkstyle, PMD, SpotBugs, japicmp and Javadoc).
   
   
   ---
   
   - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
   - [x] Read the [ASF Generative Tooling 
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use 
Artificial Intelligence (AI).
   - [x] I used AI to create any part of, or all of, this pull request. Which 
AI tool was used to create this pull request, and to what extent did it 
contribute?
   - [x] Run a successful build using the default 
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command 
line by itself.
   - [x] Write unit tests that match behavioral changes, where the tests fail 
if the changes to the runtime are not applied. This may not always be possible, 
but it is a best practice.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Each commit in the pull request should have a meaningful subject line 
and body. Note that a maintainer may squash commits during the merge process.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to