AmarGhugare opened a new pull request, #930:
URL: https://github.com/apache/commons-io/pull/930

   When a CR-terminated line is followed by an unfinished line, `Tailer` 
records its restart position one byte too far ahead. The next poll drops the 
unfinished line's first byte. For example, starting with `a\rb` and appending 
`c\n` reports `[a, c]` instead of `[a, bc]`.
   
   Keep the restart position at the byte that starts the next line. Add a 
synchronous regression covering CR, LF, and CRLF, four buffer sizes, both 
reopen modes, and successive appends. Eight CR cases fail before the fix; all 
24 cases pass afterward. There are no API changes.
   
   ## Validation
   
   With JDK 17 and Maven 3.10.0, targeting Java 8:
   
   - Tailer tests: 75 cases, zero failures/errors, three existing skips.
   - Ran the unfiltered default `mvn -B -ntp` build: 7,443 tests, zero 
assertion failures, seven errors, 64 skips. All seven errors are Windows 
symlink-privilege errors in `PathUtilsCopyTest` and `FileUtilsTest`. Focused 
reruns using the original production source reproduce the same seven errors. 
The full default build is not green locally.
   - The remaining verification and analysis checks passed using:
   
   ```text
   mvn -B -ntp -DskipTests -DskipITs verify apache-rat:check japicmp:cmp 
checkstyle:check spotbugs:check pmd:check javadoc:javadoc
   ```
   
   A Jira ticket has not yet been filed for this defect.
   
   ## Checklist
   
   - [x] Read the contribution guidelines.
   - [x] Added regression tests that fail before the runtime fix.
   - [x] Passed license, API compatibility, Checkstyle, SpotBugs, PMD, and 
Javadoc checks.
   - [ ] Successful unfiltered default Maven build on Windows; baseline 
privilege errors are described above.
   - [x] Explained the change and kept the commit focused.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to