samiusss opened a new pull request, #840: URL: https://github.com/apache/commons-compress/pull/840
Adds `AbstractArchiveBuilder.setMaxEntries(int)`, next to `setMaxEntryNameLength(int)`, so callers can cap how many entries a reader accepts. Why in the library: `ZipFile` and `TarFile` load every entry when they are opened, and `SevenZFile` sizes its entry table from the header. A caller cannot count entries before that memory is spent, so wrapping the input in a `BoundedInputStream` does not help here. Streaming readers enforce the same limit in `getNextEntry()`, so the option behaves the same across all formats. How: - `ZipFile` and `TarFile` check while collecting entries; `SevenZFile` checks the declared file count before building its table. - Streaming readers (ar, arj, cpio, dump, lha, tar, zip, jar) pass the entry they return through a new protected `ArchiveInputStream.countEntry(E)`. - Both paths share `ArchiveUtils.checkEntryCount(long, int)` and throw an `ArchiveException`. - The default is `Integer.MAX_VALUE`, so existing behavior is unchanged. Non-positive values are rejected, like `setMaxEntryNameLength`. `MaxEntriesTest` covers every reader: a limit equal to the entry count reads the whole archive, one less fails on the last entry. Related to COMPRESS-726, which caps the decompressed size of compressor streams; this is the archive-level counterpart. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude (Anthropic) assisted with the implementation and tests. I reviewed the change and take responsibility for it. - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
