alhudz opened a new pull request, #1873:
URL: https://github.com/apache/commons-lang/pull/1873
`StringUtils.join(Object[], String, int, int)` documents that a `null`
delimiter is treated as `""`, and its own Javadoc example
`StringUtils.join(["a", "b", "c"], null, 0, 3) = "abc"` says so directly. The
delimiter is passed unchanged to `LangCollectors.joining`, which builds a
`java.util.StringJoiner`, so every call with a `null` delimiter throws. The
sibling overloads `join(Object[], String)`, `join(List, String, int, int)` and
`join(Iterator, String)` all return `"abc"` for the same input.
Repro: `StringUtils.join(new Object[] {"a", "b", "c"}, (String) null, 0, 3)`
Expected: `"abc"`
Actual: `NullPointerException: The delimiter must not be null`
Fix: map the delimiter through `ObjectUtils.toString` before it reaches the
collector, the same normalisation `join(Iterator, String)` already applies.
Non-null delimiters are unchanged. The new assertions in
`StringUtilsTest.testJoin_ArrayString_EmptyDelimiter` fail before the change
(NPE at the first new assertion) and pass after.
Thanks for your contribution to [Apache
Commons](https://commons.apache.org/)! Your help is appreciated!
Before you push a pull request, review this list:
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [x] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [x] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute?
- [ ] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself. Every goal passed locally (101903 tests, rat, checkstyle,
japicmp, spotbugs, javadoc) except `pmd:check`, which fails with `skin cannot
be null` on an untouched `master` as well in my offline environment.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]