simpleqt commented on code in PR #458:
URL: https://github.com/apache/commons-codec/pull/458#discussion_r4585099577


##########
src/changes/changes.xml:
##########
@@ -61,7 +61,9 @@ The <action> type attribute can be add,update,fix,remove.
       <action type="fix" dev="ggregory" due-to="Gary Gregory">URLCodec now 
uses the JVM default charset for null charset names in its constructor, 
encoding, and decoding.</action>
       <action type="fix" dev="ggregory" due-to="Gary Gregory">StringUtils now 
uses the JVM default charset for null charset names in getBytesUnchecked and 
newString.</action>
       <action type="fix" dev="ggregory" due-to="Gary 
Gregory">BCodec.encode(String, String) now wraps illegal charset names in 
EncoderException, consistent with unsupported charset names.</action>
-      <action type="fix" dev="ggregory" due-to="Gary 
Gregory">QCodec.encode(String, String) now wraps illegal charset names in 
EncoderException, consistent with unsupported charset names.</action>      <!-- 
ADD -->
+      <action type="fix" dev="ggregory" due-to="Gary 
Gregory">QCodec.encode(String, String) now wraps illegal charset names in 
EncoderException, consistent with unsupported charset names.</action>

Review Comment:
   Removed. `src/changes/changes.xml` is no longer touched: the branch is the 
Java change plus the regression test only, now at `fa2997c` (2 files, +29/-1).
   
   The CI run on the previous head was green (10 checks, including `Java CI`); 
I cannot tell yet whether the new head needs another approval before it runs, 
and I am not claiming one.
   
   I left the pull request as a draft, as you asked, and will not touch 
`src/changes/changes.xml` in any of my open pull requests.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to