simpleqt commented on PR #1878: URL: https://github.com/apache/commons-lang/pull/1878#issuecomment-6915074446
Thanks for taking it, and for the credit in `changes.xml`. Guarding with `endIndex <= startIndex` before the subtraction is cleaner than changing the arithmetic type: it avoids the overflow entirely and covers every overload, the `List` ones included, which mine also touched but in a noisier way. On the `changes.xml` edit: sorry about that. I followed the `AGENTS.md` that `commons-parent` publishes, which tells agents to append `action` elements there. Since your convention is the opposite, I have removed that file from the four pull requests I still have open in Commons: commons-codec#458, commons-csv#644, commons-collections#757 and commons-net#424. They now touch only the source and the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
