joao-jordy commented on PR #1862: URL: https://github.com/apache/commons-lang/pull/1862#issuecomment-6962037120
@garydgregory thanks for the review. You were right that the bracket-only case has no defined answer: \`getCanonicalName\` already rejects it, and the raw-name methods should not invent output for it. I split this PR into two: - #1886: the O(n^2) fix in \`getShortClassName\`, which is behaviour-preserving for valid names. - #1887: makes \`getPackageName\` and \`getShortClassName\` throw \`IllegalArgumentException\` for bracket-only input, matching the canonical methods. japicmp reports no compatibility issues. Closing this one in favour of those. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
