AmarGhugare opened a new pull request, #1889:
URL: https://github.com/apache/commons-lang/pull/1889

   [LANG-1840](https://issues.apache.org/jira/browse/LANG-1840)
   
   Since 3.21.0, `ToStringStyle.appendDetail(StringBuffer, String, Map)` sends 
each map key and value through `appendInternal(...)`, so a null key or value 
now reaches `appendDetail(StringBuffer, String, Object)`. 
`RecursiveToStringStyle` checks `value != null` before recursing. The 
`MultilineRecursiveToStringStyle` override calls `value.getClass()` without 
that check and throws a `NullPointerException`.
   
   This change adds the same null check. A null now goes to the superclass and 
prints as `null`, the same as `RecursiveToStringStyle` and `Map.toString()`.
   
   Tests in `MultilineRecursiveToStringStyleTest`:
   - map field with a null value (this fails on master with the NPE from the 
ticket)
   - map field with a null key
   - `appendDetail(buffer, fieldName, (Object) null)` called directly
   
   Before you push a pull request, review this list:
   
   - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
   - [x] Read the [ASF Generative Tooling 
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use 
Artificial Intelligence (AI).
   - [x] I used AI to create any part of, or all of, this pull request. Which 
AI tool was used to create this pull request, and to what extent did it 
contribute? Claude Code (Anthropic) found the root cause and drafted the fix 
and tests. I reviewed the change and ran the build.
   - [x] Run a successful build using the default 
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command 
line by itself.
   - [x] Write unit tests that match behavioral changes, where the tests fail 
if the changes to the runtime are not applied. This may not always be possible, 
but it is a best practice.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Each commit in the pull request should have a meaningful subject line 
and body. Note that a maintainer may squash commits during the merge process.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to