rootvector2 opened a new pull request, #547:
URL: https://github.com/apache/commons-bcel/pull/547

   `InstConstraintVisitor.visitGETFIELD` and `visitPUTFIELD` only check that 
the objectref is an `ObjectType` or `null`, never that it is an instance of the 
class named by the field reference. Pass 3b therefore returns `VERIFIED_OK` for 
a method doing `aload_0; getfield Foo.x:I` where local 0 is a `String`, while 
HotSpot rejects the same class with `VerifyError: Incompatible type for getting 
or setting field`. Found while auditing the objectref checks in 
`InstConstraintVisitor`: `visitINVOKEVIRTUAL` and `visitINVOKESPECIAL` both 
enforce `Repository.instanceOf(objRefClassName, theClass)`, the field 
instructions don't.
   
   Apply the same `Repository.instanceOf` check to the getfield/putfield 
objectref; `null`, array and uninitialized objectrefs keep their existing 
handling. `VerifierFieldAccessTest` asserts getfield/putfield on a `String` is 
rejected (fails before, passes after) and the same accesses on the declaring 
class still verify. As a false-positive check I ran Pass 3a/3b over all 2563 
methods in BCEL's own `target/classes`: the same 40 pre-existing rejections 
before and after, none from the new check.
   
   
   - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
   - [ ] Read the [ASF Generative Tooling 
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use 
Artificial Intelligence (AI).
   - [x] I used AI to create any part of, or all of, this pull request. Which 
AI tool was used to create this pull request, and to what extent did it 
contribute? Claude (Anthropic) found the issue and drafted the fix and test; I 
reviewed them before submitting.
   - [x] Run a successful build using the default 
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command 
line by itself.
   - [x] Write unit tests that match behavioral changes, where the tests fail 
if the changes to the runtime are not applied. This may not always be possible, 
but it is a best practice.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Each commit in the pull request should have a meaningful subject line 
and body. Note that a maintainer may squash commits during the merge process.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to