[
https://issues.apache.org/jira/browse/LANG-662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Yandell closed LANG-662.
------------------------------
Resolution: Fixed
svn ci -m "Adding first method check from Math's MathUtils.gcd method; and unit
tests showing that this was needed. Bug reported and solved by Christian Semrau
[LANG-662]"
Sending src/main/java/org/apache/commons/lang3/math/Fraction.java
Sending src/test/java/org/apache/commons/lang3/math/FractionTest.java
Transmitting file data ..
Committed revision 1059749.
> org.apache.commons.lang3.math.Fraction does not reduce (Integer.MIN_VALUE,
> 2^k)
> -------------------------------------------------------------------------------
>
> Key: LANG-662
> URL: https://issues.apache.org/jira/browse/LANG-662
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.math.*
> Affects Versions: 3.0
> Reporter: Christian Semrau
> Priority: Minor
> Fix For: 3.0
>
>
> The greatestCommonDivisor method in class Fraction does not find the gcd of
> Integer.MIN_VALUE and 2^k, and this case can be triggered by taking
> Integer.MIN_VALUE as the numerator. Note that the case of taking
> Integer.MIN_VALUE as the denominator is handled explicitly in the
> getReducedFraction factory method.
> {code:title=FractionTest.java|borderStyle=solid}
> // additional test cases
> public void testReducedFactory_int_int() {
> // ...
> f = Fraction.getReducedFraction(Integer.MIN_VALUE, 2);
> assertEquals(Integer.MIN_VALUE / 2, f.getNumerator());
> assertEquals(1, f.getDenominator());
> public void testReduce() {
> // ...
> f = Fraction.getFraction(Integer.MIN_VALUE, 2);
> result = f.reduce();
> assertEquals(Integer.MIN_VALUE / 2, result.getNumerator());
> assertEquals(1, result.getDenominator());
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
