[
https://issues.apache.org/jira/browse/DBCP-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phil Steitz resolved DBCP-337.
------------------------------
Resolution: Fixed
Patch with slight mods to the tests committed in r1097625
(trunk) and r1097630 (1.4 branch).
Thanks for the patch!
> equals in DelegatingXXX is not reflexive and could be faster
> ------------------------------------------------------------
>
> Key: DBCP-337
> URL: https://issues.apache.org/jira/browse/DBCP-337
> Project: Commons Dbcp
> Issue Type: Bug
> Reporter: Rob Gansevles
> Priority: Minor
> Fix For: 1.3.1, 1.4.1
>
> Attachments: delegate_equals_patch
>
>
> The equals() methods in the different DelegatingXXX classes do not start with
> a simple object equality check for this.
> The equals methods do not implement the contract for equals because
> x.equals(x) where getInnermostDelegate() for x returns null will return false.
> Performance-wise the check would help since you don't need to walk the
> delegate tree.
> I will attach a patch.
> Rob
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
