[
https://issues.apache.org/jira/browse/EXEC-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058512#comment-13058512
]
Kedar Raybagkar commented on EXEC-36:
-------------------------------------
StringUtils also needs a change to handle the issue of quote...
Trip the ending as well as starting double or single quote if they start or end
with quotes.
method static String quoteArgument...
while((argument.trim().endsWith(SINGLE_QUOTE) ||
argument.trim().endsWith(DOUBLE_QUOTE))
&& cleanedArgument.startsWith(SINGLE_QUOTE) ||
cleanedArgument.startsWith(DOUBLE_QUOTE)) {
cleanedArgument = cleanedArgument.substring(1);
}
while((argument.trim().startsWith(SINGLE_QUOTE) ||
argument.trim().startsWith(DOUBLE_QUOTE))
&& cleanedArgument.endsWith(SINGLE_QUOTE) ||
cleanedArgument.endsWith(DOUBLE_QUOTE)) {
cleanedArgument = cleanedArgument.substring(0,
cleanedArgument.length() - 1);
}
> CommandLine does not work with double quote or single quote correctly
> ---------------------------------------------------------------------
>
> Key: EXEC-36
> URL: https://issues.apache.org/jira/browse/EXEC-36
> Project: Commons Exec
> Issue Type: Bug
> Affects Versions: 1.0
> Environment: Ubuntu 704, JDK1.6
> Reporter: Kai Hu
> Assignee: Siegfried Goeschl
> Priority: Critical
> Attachments: ExecParseUtils.java, ExecParseUtilsTest.java
>
>
> Please review and run the following junit test, either apache ant or apache
> exec does not handle the qoute in the arguments correctly.
> @Test
> public void shouldHandleTheDoubelQuote() throws Exception {
> String commandline = "./script/jrake cruise:publish_installers "
> + "INSTALLER_VERSION=unstable_2_1 "
> + "INSTALLER_PATH=\"/var/lib/ cruise-agent/installers\" "
> + "INSTALLER_DOWNLOAD_SERVER='something'"
> + "WITHOUT_HELP_DOC=true";
> CommandLine line = CommandLine.parse(commandline);
> String[] args = line.getArguments();
> assertThat(args[0], is("cruise:publish_installers"));
> assertThat(args[1], is("INSTALLER_VERSION=unstable_2_1"));
> assertThat(args[2], is("INSTALLER_PATH=\"/var/lib/
> cruise-agent/installers\""));
> assertThat(args[3], is("INSTALLER_DOWNLOAD_SERVER='something'"));
> assertThat(args[4], is("WITHOUT_HELP_DOC=true"));
> }
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
