[ 
https://issues.apache.org/jira/browse/SANDBOX-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059980#comment-13059980
 ] 

Simone Tripodi commented on SANDBOX-338:
----------------------------------------

nice, it looks much better now :)

anyway, two minor observations:

 * there's a typo in {{GraphColoingBackTrackingTestCase}}, should be 
{{GraphColoringBackTrackingTestCase}};
 * I don't see useful having the {{GraphUtils.createColorsList()}} method in 
{{GraphUtils}} class, since it is required only for _coloring_ problem, I'd 
suggest you relocating it.

TIA, ciao ;)

> [Graph Coloring] Generic iterable set of color
> ----------------------------------------------
>
>                 Key: SANDBOX-338
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-338
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Graph
>            Reporter: Marco Speranza
>            Priority: Minor
>         Attachments: GenericIterableColorSet-Fixed.patch, 
> GenericIterableColorSet.patch
>
>
> Hi folk, here is a little improvement of graph coloring. In order to 
> generalize the APIs I changed the color {{Set}} with {{Iterable}} and 
> furthermore generalized the color type.
> WDYT?
> Looking forward your comments.
> have a nice day

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to