[ 
https://issues.apache.org/jira/browse/SANDBOX-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060158#comment-13060158
 ] 

Simone Tripodi commented on SANDBOX-339:
----------------------------------------

this is something that we really need to add, cool idea!!!

anyway, I'd like you could provide a smarter version... :P

{{Properties}} sounds too flexible - users could add anything their fantasy 
suggests - and renderers could raise an error when parsing wrong attributes 
instead of just ignoring them; at the same time, DOT language shouldn't be so 
large, so I'd suggest you working on a modeling DOT Vertex attributes - maybe 
one POJO (with defaults) should be enough.

Moreover, there are cases that the patch doesn't handle - the bigger part, I 
deduce - where a single configuration for all graph vertices is more than 
enough.

Good job, ciao!
Simo

> [Dot Export] Adding vertex attribute
> ------------------------------------
>
>                 Key: SANDBOX-339
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-339
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Graph
>            Reporter: Marco Speranza
>            Priority: Minor
>         Attachments: DotExport-AddingVertexAttribute.patch
>
>
> Hi folk, I just made a little improvement to Dot Export. I added the 
> possibility to customize the attributes of the vertices through a 
> {{Map<Vertex, Properties>}}
> Looking forward your comments.
> bye

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to