[
https://issues.apache.org/jira/browse/MATH-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100397#comment-13100397
]
Sebb commented on MATH-658:
---------------------------
The body format (3rd line onwards) is OK, but the header lines are incorrect.
They should look something like:
{code}
Index: src/main/java/org/apache/commons/math/util/FastMath.java
===================================================================
--- src/main/java/org/apache/commons/math/util/FastMath.java (revision
1166437)
+++ src/main/java/org/apache/commons/math/util/FastMath.java (working copy)
{code}
This was created by updating the file in an SVN working copy and then creating
the patch (I used Eclipse, specifying project-relative mode, but svn diff would
produce much the same output).
Your patch has completely different names and paths for the input and output
files:
{code}
--- D:/DOCUME~1/tanguyy/LOCALS~1/Temp/FastMath.java-revBASE.svn000.tmp.java
jeu. sept. 8 16:28:36 2011
+++
D:/DONNEES/ATELIER_JAVA/workspace/Commons-Math_Trunk/src/main/java/org/apache/commons/math/util/FastMath.java
jeu. sept. 8 16:10:02 2011
{code}
This means it's impossible to apply the patch automatically.
However, it's not too difficult to fix the header lines, e.g. in the above case
to:
{code}
--- FastMath.java jeu. sept. 8 16:28:36 2011
+++ FastMath.java jeu. sept. 8 16:10:02 2011
{code}
and the patch can then be applied in the appropriate directory.
No need to resubmit these particular patches, but if you submit any more please
use the proper unified diff format relative to the top-level project directory,
so paths start with src/.
> Dead code in FastMath.pow(double, double) and some improvement in test
> coverage
> -------------------------------------------------------------------------------
>
> Key: MATH-658
> URL: https://issues.apache.org/jira/browse/MATH-658
> Project: Commons Math
> Issue Type: Improvement
> Reporter: Yannick TANGUY
> Priority: Minor
> Fix For: 3.0
>
> Attachments: FastMath.java.diff, FastMathTest.java,
> FastMathTest.java.diff
>
>
> This issue concerns the FastMath class and its test class.
> (1) In the double pow(double, double) function, there are 2 identical "if"
> blocks. The second one can be suppressed.
> if (y < 0 && y == yi && (yi & 1) == 1) {
> return Double.NEGATIVE_INFINITY;
> }
> // this block is never used -> to be suppressed
> if (y < 0 && y == yi && (yi & 1) == 1) {
> return -0.0;
> }
> if (y > 0 && y == yi && (yi & 1) == 1) {
> return -0.0;
> }
> (2) To obtain better code coverage, we added some tests case in
> FastMathTest.java (see attached file)
> - Added test for log1p
> - Added tests in testPowSpecialCases()
> - Added tests for a 100% coverage of acos().
> - Added tests for a 100% coverage of asin().
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
