[ 
https://issues.apache.org/jira/browse/SANSELAN-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115462#comment-13115462
 ] 

Gary Lucas commented on SANSELAN-54:
------------------------------------

I have implemented fixes for this.  The changes were quite minor. I tested them 
against the output from Java's NIO ByteBuffer class (on the theory that Java 
can serve as a baseline implementation).  Since I'm pretty new to Apache and 
its procedures, I was wondering if somebody wanted to "mentor" me on turning 
this in (review my code, etc.).
                
> Tiff (exif) tags of type double written in wrong byte order
> -----------------------------------------------------------
>
>                 Key: SANSELAN-54
>                 URL: https://issues.apache.org/jira/browse/SANSELAN-54
>             Project: Commons Sanselan
>          Issue Type: Bug
>         Environment: Tested under Windows XP.  Potentally all platforms.
>            Reporter: Gary Lucas
>
> Reviewing BinaryFileFunctions.java method convertDoubleToByteArray and 
> convertDoubleArrayToByteArray there are two blocks of code, one for 
> BYTE_ORDER_MOTOROLA (big endian) and one for BYTE_ORDER_INTEL (little 
> endian).  These are backwards.  
> The convertByteArrayToDouble, on the other hand appears to be correct.  A 
> reasonable test procedure would be to see if these two sets of methods are 
> mutually consistent.
> The same problem appears to be the case for the "Float" variants, but not the 
> Integer variants.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to