[
https://issues.apache.org/jira/browse/IO-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146045#comment-13146045
]
Pier-Luc Caron St-Pierre edited comment on IO-291 at 11/8/11 2:38 AM:
----------------------------------------------------------------------
I built on top of your patch. So if you apply my patch (io-291-v5.patch) from
scratch, you should have our combined changes.
* I have implemented the directoryContains(final File directory, final File
child)
* I have added some test case for the newly implemented function.
* I have added some javadoc, renamed some parameters
* I have corrected the code style of the test to match the original style.
We have some issues to address :
* Actually the test case fail on testSameFile() because the case is tester on
a file. It fail the rule that a directory cannot be a file
* Does a directory contain itself? I do not have strong opinions about that.
* Does a file contain itself? I do not have strong opinions about that.
* In the scope of the method "directoryContains(final File directory, final
File child)", what will happens if the files is an empty collection?
was (Author: plcstpierre):
I build on top of your patch. So if you apply my patch (io-291-v5.patch)
from scratch, you should have our combined changes.
* I have implemented the directoryContains(final File directory, final File
child)
* I have added some test case for the newly implemented function.
* I have Added some javadoc, renamed some parameters
* I have corrected the code style of the test to match the original style.
We have some issues to address :
* Actually the test case fail on testSameFile() because the case is tester on
a file. It fail the rule that a directory cannot be a file
* Does a directory contain itself? I do not have strong opinions about that.
* Does a file contain itself? I do not have strong opinions about that.
* In the scope of the method "directoryContains(final File directory, final
File child)", what will happens if the files is an empty collection?
> Add new function FileUtils.isContained
> --------------------------------------
>
> Key: IO-291
> URL: https://issues.apache.org/jira/browse/IO-291
> Project: Commons IO
> Issue Type: New Feature
> Components: Utilities
> Affects Versions: 2.1
> Reporter: Pier-Luc Caron St-Pierre
> Assignee: Gary D. Gregory
> Labels: patch
> Fix For: 2.1
>
> Attachments: io-291-simple.diff, io-291-v5.patch
>
>
> I added a function that determines whether the specified leaf is contains by
> the specified composite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
