[
https://issues.apache.org/jira/browse/SANSELAN-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emmanuel Bourg updated SANSELAN-44:
-----------------------------------
Description:
A patch has been done to read thumbnail from exif metada (see bug 38). But
there is a bug if exif is null (NullpointerException):
{code:java}
public BufferedImage getEXIFThumbnail() throws ImageReadException,
IOException {
ArrayList dirs = exif.getDirectories();
for (int i = 0; i < dirs.size(); i++) {
TiffImageMetadata.Directory dir =
(TiffImageMetadata.Directory) dirs
.get(i);
// Debug.debug("dir", dir);
BufferedImage image = dir.getThumbnail();
if (null != image)
return image;
JpegImageData jpegImageData = dir.getJpegImageData();
if(jpegImageData!=null){
ByteArrayInputStream input = new
ByteArrayInputStream(jpegImageData.data);
image = ImageIO.read(input);
if (image!=null)
return image;
}
}
return null;
}
{code}
This patch correct the bug:
{code:java}
if (exif!= null) {
ArrayList dirs = exif.getDirectories();
for (int i = 0; i < dirs.size(); i++) {
TiffImageMetadata.Directory dir = (TiffImageMetadata.Directory)
dirs.get(i);
// Debug.debug("dir", dir);
BufferedImage image = dir.getThumbnail();
if (null != image) {
return image;
}
JpegImageData jpegImageData = dir.getJpegImageData();
if (jpegImageData != null) {
ByteArrayInputStream input = new
ByteArrayInputStream(jpegImageData.data);
image = ImageIO.read(input);
if (image != null) {
return image;
}
}
}
}
return null;
{code}
was:
A patch has been done to read thumbnail from exif metada (see bug 38). But
there is a bug if exif is null (NullpointerException):
<code>
public BufferedImage getEXIFThumbnail() throws ImageReadException,
IOException {
ArrayList dirs = exif.getDirectories();
for (int i = 0; i < dirs.size(); i++) {
TiffImageMetadata.Directory dir =
(TiffImageMetadata.Directory) dirs
.get(i);
// Debug.debug("dir", dir);
BufferedImage image = dir.getThumbnail();
if (null != image)
return image;
JpegImageData jpegImageData = dir.getJpegImageData();
if(jpegImageData!=null){
ByteArrayInputStream input = new
ByteArrayInputStream(jpegImageData.data);
image = ImageIO.read(input);
if (image!=null)
return image;
}
}
return null;
}
</code>
This patch correct the bug:
<code>
if (exif!= null) {
ArrayList dirs = exif.getDirectories();
for (int i = 0; i < dirs.size(); i++) {
TiffImageMetadata.Directory dir = (TiffImageMetadata.Directory)
dirs.get(i);
// Debug.debug("dir", dir);
BufferedImage image = dir.getThumbnail();
if (null != image) {
return image;
}
JpegImageData jpegImageData = dir.getJpegImageData();
if (jpegImageData != null) {
ByteArrayInputStream input = new
ByteArrayInputStream(jpegImageData.data);
image = ImageIO.read(input);
if (image != null) {
return image;
}
}
}
}
return null;
</code>
Affects Version/s: (was: 0.94-incubator)
0.97
Fix Version/s: 1.0
> JpegImageMetadata getEXIFThumbnail may raise a null pointer exception
> ---------------------------------------------------------------------
>
> Key: SANSELAN-44
> URL: https://issues.apache.org/jira/browse/SANSELAN-44
> Project: Commons Sanselan
> Issue Type: Bug
> Affects Versions: 0.97
> Reporter: Alain
> Assignee: Sebb
> Fix For: 1.0
>
>
> A patch has been done to read thumbnail from exif metada (see bug 38). But
> there is a bug if exif is null (NullpointerException):
> {code:java}
> public BufferedImage getEXIFThumbnail() throws ImageReadException,
> IOException {
> ArrayList dirs = exif.getDirectories();
> for (int i = 0; i < dirs.size(); i++) {
> TiffImageMetadata.Directory dir =
> (TiffImageMetadata.Directory) dirs
> .get(i);
> // Debug.debug("dir", dir);
> BufferedImage image = dir.getThumbnail();
> if (null != image)
> return image;
> JpegImageData jpegImageData = dir.getJpegImageData();
> if(jpegImageData!=null){
> ByteArrayInputStream input = new
> ByteArrayInputStream(jpegImageData.data);
> image = ImageIO.read(input);
> if (image!=null)
> return image;
> }
> }
> return null;
> }
> {code}
> This patch correct the bug:
> {code:java}
> if (exif!= null) {
> ArrayList dirs = exif.getDirectories();
> for (int i = 0; i < dirs.size(); i++) {
> TiffImageMetadata.Directory dir =
> (TiffImageMetadata.Directory) dirs.get(i);
> // Debug.debug("dir", dir);
> BufferedImage image = dir.getThumbnail();
> if (null != image) {
> return image;
> }
> JpegImageData jpegImageData = dir.getJpegImageData();
> if (jpegImageData != null) {
> ByteArrayInputStream input = new
> ByteArrayInputStream(jpegImageData.data);
> image = ImageIO.read(input);
> if (image != null) {
> return image;
> }
> }
> }
> }
> return null;
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
