[ 
https://issues.apache.org/jira/browse/NET-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebb updated NET-423:
---------------------

    Description: 
When setting ControlKeepAliveTimeout. FTPClient.__storeFile might fail when 
waiting for ack on ControlConnection.

Current code:
{noformat}
        // Get the transfer response
        boolean ok = completePendingCommand();
        if (csl != null) {
            csl.cleanUp(); // fetch any outstanding keepalive replies
        }
{noformat}
While CSL is active, the ControlConnection timeout is set to 1 sec., if using 
default. This timeout value doesn't leave much room in terms of network/end 
point latency.

Replacing the code fragment above with the following fragment probably solves 
the problem (If proper ControlConnection timeout value is set):
{noformat}
        if (csl != null) {
            csl.cleanUp(); // fetch any outstanding keepalive replies
        }
        // Get the transfer response
        boolean ok = completePendingCommand();
{noformat}

One workaround is to set ControlKeepAliveReplyTimeout to a higher value.


  was:
When setting ControlKeepAliveTimeout. FTPClient.__storeFile might fail when 
waiting for ack on ControlConnection.

Current code:
        // Get the transfer response
        boolean ok = completePendingCommand();
        if (csl != null) {
            csl.cleanUp(); // fetch any outstanding keepalive replies
        }
While CSL is active, the ControlConnection timeout is set to 1 sec., if using 
default. This timeout value doesn't leave much room in terms of network/end 
point latency.

Replacing the code fragment above with the following fragment probably solves 
the problem (If proper ControlConnection timeout value is set):
        if (csl != null) {
            csl.cleanUp(); // fetch any outstanding keepalive replies
        }
        // Get the transfer response
        boolean ok = completePendingCommand();


One workaround is to set ControlKeepAliveReplyTimeout to a higher value.


    
> FTPClient.storeFIle might fail when ControlKeepAliveTimeout is set
> ------------------------------------------------------------------
>
>                 Key: NET-423
>                 URL: https://issues.apache.org/jira/browse/NET-423
>             Project: Commons Net
>          Issue Type: Bug
>          Components: FTP
>    Affects Versions: 3.0.1
>            Reporter: Jens Koch
>            Priority: Minor
>
> When setting ControlKeepAliveTimeout. FTPClient.__storeFile might fail when 
> waiting for ack on ControlConnection.
> Current code:
> {noformat}
>         // Get the transfer response
>         boolean ok = completePendingCommand();
>         if (csl != null) {
>             csl.cleanUp(); // fetch any outstanding keepalive replies
>         }
> {noformat}
> While CSL is active, the ControlConnection timeout is set to 1 sec., if using 
> default. This timeout value doesn't leave much room in terms of network/end 
> point latency.
> Replacing the code fragment above with the following fragment probably solves 
> the problem (If proper ControlConnection timeout value is set):
> {noformat}
>         if (csl != null) {
>             csl.cleanUp(); // fetch any outstanding keepalive replies
>         }
>         // Get the transfer response
>         boolean ok = completePendingCommand();
> {noformat}
> One workaround is to set ControlKeepAliveReplyTimeout to a higher value.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to