In BeanProcessor#isCompatibleType, can Integer.class.isInstance(value) be
replaced by value instanceof Integer (etc)?
---------------------------------------------------------------------------------------------------------------------
Key: DBUTILS-85
URL: https://issues.apache.org/jira/browse/DBUTILS-85
Project: Commons DbUtils
Issue Type: Improvement
Reporter: Sebb
Priority: Minor
In BeanProcessor#isCompatibleType, there is one valid use of the dynamic
Class#isInstance() method, followed by several that could surely use the static
instanceof keyword:
{noformat}
if (value == null || type.isInstance(value)) { // <== this needs to be dynamic
return true;
} else if (type.equals(Integer.TYPE) && Integer.class.isInstance(value)) { //
<== this doesn't
return true;
} else if (type.equals(Long.TYPE) && Long.class.isInstance(value)) { // <==
nore here
return true;
...
{noformat}
Seems unnecessary (and more verbose) to use the dynamic method where the target
class is known at compile time.
Or am I missing something here?
If so, let's document why the dynamic method is needed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
