[ 
https://issues.apache.org/jira/browse/SANDBOX-370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Simone Tripodi resolved SANDBOX-370.
------------------------------------

    Resolution: Fixed

Patch applied, thanks for your efforts Matteo!!! see 
[r1237585|https://svn.apache.org/viewvc?view=revision&revision=1237585] for 
more details!

While keeping the core implementation, I applied some minor modifications to 
your patch, one of the purposes of exporters is be used via fluent APIs as 
well, so tests now look like:

{code}
   @Test
    public void shouldPrintGraphMLFormat()
        throws Exception
    {
        export( actual ).to( System.out ).usingGraphMLFormat();
    }
{code}

As a side note: the {Basic} implementations shall not be used to check 
Vertex/Edge type - we expect users will provide façades on their own data, so I 
moved checks over Labeled/Weighted interfaces
                
> GraphML format exporter
> -----------------------
>
>                 Key: SANDBOX-370
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-370
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Graph
>    Affects Versions: Nightly Builds
>            Reporter: Matteo Moci
>            Assignee: Simone Tripodi
>            Priority: Minor
>              Labels: export, graph, xml
>         Attachments: SANDBOX-370.patch
>
>   Original Estimate: 6h
>  Remaining Estimate: 6h
>
> Commons-graph should have some way to read and write graph representations 
> encoded with GraphML - http://graphml.graphdrawing.org/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to