[
https://issues.apache.org/jira/browse/SANDBOX-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198674#comment-13198674
]
Benedikt Ritter commented on SANDBOX-379:
-----------------------------------------
Hey, thanks for the feedback. Let me comment on that ;)
{quote}
{{BeanAccessorTestCase}} has only 1 test method that can be included in
BeanUtilsTest; the describes is protected (and there's no reason why), it can
be {{private final}}.
{quote}
I created BeanAccessorTestCase as a Unit Test for DefaultBeanAccessor (wow,
supprise ;) ), having in mind, that there are some more methods to be tested
like clone(), populate() and copyProperties(). BeanUtilsTest is a unit test for
testing the factory methods in BeanUtils. Adding tests for all methods in
BeanAccessor to BeanUtilsTest would lead to a huge test class, that tests more
than one class at once. So I thought creating a new test for
DefaultBeanAccessor would be a good idea, regarding separation of concerns.
What do you think?
The protected String array was copied from BeanUtils1, but you're right, there
is no reason to have it protected. I'll change it.
{quote}
Same thing for {{Jira157TestCase}}, test methods can be moved in the
{{BeanUtilsTest}} class; methods name have to be renamed stripping the
{{testIssue_BEANUTILS_157_BeanUtils}} prefix;
{quote}
I really liked the idea to have a dedicated test for a bug. To be honest, I was
thinking about proposing that in my company :) But if you don't like it, I'll
move it depending on your comment to the above mentioned topic.
{quote}
{{AccessibleObjectsRegistry#getMethodsRegistry()}} can be referenced statically
in {{PropertyDescriptorsRegistry;}}
{quote}
I'll change it.
{quote}
{{PropertyDescriptorsRegistry#makeMethodsAccessible}} returns the same
{{PropertyDescriptor}} input instance, there's no reason that method has a
return statement, signature can be changed to void.
{quote}
ok :)
Have a nice day!
Benedikt
> [BeanUtils2] Implement describe() on DefaultBeanAccessor
> ---------------------------------------------------------
>
> Key: SANDBOX-379
> URL: https://issues.apache.org/jira/browse/SANDBOX-379
> Project: Commons Sandbox
> Issue Type: Improvement
> Components: BeanUtils2
> Affects Versions: Nightly Builds
> Reporter: Benedikt Ritter
> Attachments: SANDBOX-379.txt
>
>
> Implement the above mentioned method an corresponding unit tests
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
