[ 
https://issues.apache.org/jira/browse/SANDBOX-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213603#comment-13213603
 ] 

Claudio Squarcella commented on SANDBOX-395:
--------------------------------------------

Cool, I just committed!
                
> Correct names for classes and variables related to operations on weights
> ------------------------------------------------------------------------
>
>                 Key: SANDBOX-395
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-395
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Graph
>            Reporter: Claudio Squarcella
>            Assignee: Claudio Squarcella
>            Priority: Minor
>              Labels: graph, operations, weight
>         Attachments: 
> SANDBOX-395_CorrectClassAndVariableNamesForWeightOperations.patch
>
>
> Hi all,
> as discussed in ML already the current classes/variables that refer to 
> operations on weights can be renamed for better expressiveness:
> * all the classes under {{weight.primitive}} should be renamed from {{XXX}} 
> to {{XXXOperations}} because they actually contain operations on weights 
> (they do not represent weights themselves);
> * in the actual algorithms, all variable names for weight operations should 
> actually be something like {{weightOperations}} instead of the name of the 
> interface (e.g. {{orderedMonoid}}).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to