[
https://issues.apache.org/jira/browse/SANDBOX-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222266#comment-13222266
]
Simone Tripodi commented on SANDBOX-401:
----------------------------------------
Just saw the patch and indeed you can do it better ;) Don't get crazy with
[Rube Goldber|http://www.rubegoldberg.com/?page=home]'s machines, just declare
the {{private int hashCode}} as {{final}} and compute it just after all fields
members are built. Why you do need {{computeHashCode()}}? Just to add another
piece in the machine? ;)
{{AccessbileObjectDescirptor}} is already immutable - I don't mind if init
takes longer - that op will be performed only once and acceding to that field
will be always linear.
Looking forward next patch, TIA.
> [BeanUtils2] Performance improvement: store hash code of
> AccessibleObjectDescriptor as member variable
> ------------------------------------------------------------------------------------------------------
>
> Key: SANDBOX-401
> URL: https://issues.apache.org/jira/browse/SANDBOX-401
> Project: Commons Sandbox
> Issue Type: Improvement
> Components: BeanUtils2
> Affects Versions: Nightly Builds
> Reporter: Benedikt Ritter
> Attachments: SANDBOX-401.txt
>
>
> As discussed on the ML, we should store the hash code of
> AccessibleObjectDescriptor in a private member variable after it has been
> computed the first time. The computed value can be returned on subsequent
> invocations. Since AccessibleObjectDescriptor is immutable (all of its fields
> are final) the hash code can never change, once an AccessibleObjectDescriptor
> has been initialized.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
