[ 
https://issues.apache.org/jira/browse/CSV-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226591#comment-13226591
 ] 

Sebb commented on CSV-43:
-------------------------

OK, but so long as the predefined formats are "frozen", it would still be 
possible to code the fluent API more efficiently.

The simplest way would be to add a flag that stops further updates.
                
> CSVFormat fluent API is rather inefficient
> ------------------------------------------
>
>                 Key: CSV-43
>                 URL: https://issues.apache.org/jira/browse/CSV-43
>             Project: Commons CSV
>          Issue Type: Improvement
>            Reporter: Sebb
>
> The implementation of the CSVFormat fluent API is rather inefficient, as each 
> method invocation clones the original class instance.
> Now that the fields are volatile, it would be possible to do away with the 
> clone() calls entirely.
> This would mean that the format could be updated later.
> If such usage is not desirable, then perhaps consider adding some kind of 
> "freeze" method to prevent further changes.
> Or perhaps the parse() and format() methods could perform the freeze (e.g. 
> set a flag to disable further updates).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to