[
https://issues.apache.org/jira/browse/CSV-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benedikt Ritter updated CSV-55:
-------------------------------
Attachment: CSV-55.txt
patch attached ;)
> Replace while(true)-loop in CSVParser.getRecord() with do-while-loop
> --------------------------------------------------------------------
>
> Key: CSV-55
> URL: https://issues.apache.org/jira/browse/CSV-55
> Project: Commons CSV
> Issue Type: Improvement
> Components: Parser
> Affects Versions: 1.0
> Reporter: Benedikt Ritter
> Priority: Trivial
> Fix For: 1.0
>
> Attachments: CSV-55.txt
>
>
> The current implementation of {{getRecords()}} uses a while(true) loop, that
> gets canceled by an if statement:
> {code:java}
> while (true) {
> reusableToken.reset();
> lexer.nextToken(reusableToken);
> // omitted
> if(reusableToken.type != TOKEN) {
> break;
> }
> }
> {code}
> This should be replaced by a do-while-loop:
> {code:java}
> do {
> reusableToken.reset();
> lexer.nextToken(reusableToken);
> // omitted
> } while (reusableToken.type == TOKEN);
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
