[
https://issues.apache.org/jira/browse/IO-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254927#comment-13254927
]
Sebb commented on IO-323:
-------------------------
bq. There is no point on keeping on counting once you overflow.
True, but one has to detect the overflow in the first place.
This adds extra code for every invocation.
Overflow by upto Long.MAX_VALUE will result in a negative value, so the caller
can detect many cases of overflow.
Long.MAX_VALUE + Long.MAX_VALUE => -2
So we could opt for option (2), and document the possible overflow.
> What should happen in FileUtils.sizeOf[Directory] when an overflow takes
> place?
> -------------------------------------------------------------------------------
>
> Key: IO-323
> URL: https://issues.apache.org/jira/browse/IO-323
> Project: Commons IO
> Issue Type: Bug
> Components: Utilities
> Affects Versions: 2.3
> Environment: Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500)
> Maven home: C:\Java\apache-maven-3.0.4\bin\..
> Java version: 1.6.0_31, vendor: Sun Microsystems Inc.
> Java home: C:\Program Files\Java\jdk1.6.0_31\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
> Reporter: Gary D. Gregory
>
> FileUtils.sizeOf[Directory] adds longs. What should happen when an overflow
> happens?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
