[
https://issues.apache.org/jira/browse/CODEC-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258466#comment-13258466
]
Sebastien Dubois commented on CODEC-139:
----------------------------------------
Hello Gary, thanks for taking time to review this.
You're right, I didn't do my homework correctly and didn't provide unit tests.
Also, I failed to RTFM and didn't see that I should've been calling the
'update' methods of MessageDigest instead of 'digest' this was just plain wrong!
I'll try and upload a better version of my patch asap.
> DigestUtils: additional utility methods
> ---------------------------------------
>
> Key: CODEC-139
> URL: https://issues.apache.org/jira/browse/CODEC-139
> Project: Commons Codec
> Issue Type: Improvement
> Reporter: Sebastien Dubois
> Priority: Trivial
> Labels: patch
> Attachments: DigestUtils-patch.txt
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> I've slightly modified the DigestUtils class:
> - changed the visibility (protected --> public) of a few methods: these
> methods are generally useful if one just wants to get a MessageDigest
> instance for a given algorithm
> - added two 'updateDigest' methods which can be used to add more data to
> digest to the provided MessageDigest. The advantage for the one that accepts
> a String argument is that it keeps the same logic as the rest of DigestUtils
> (uses getBytesUtf8). The second one which accepts a byte array is there for
> consistency
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
