Sebb created MATH-793:
-------------------------

             Summary: OrderedTuple#hashCode() uses casting instead of boxing
                 Key: MATH-793
                 URL: https://issues.apache.org/jira/browse/MATH-793
             Project: Commons Math
          Issue Type: Bug
         Environment: OrderedTuple#hashCode() is as follows:

{code}
public int hashCode() {
    return Arrays.hashCode(components)   ^
           ((Integer) offset).hashCode() ^
           ((Integer) lsb).hashCode()    ^
           ((Boolean) posInf).hashCode() ^
           ((Boolean) negInf).hashCode() ^
           ((Boolean) nan).hashCode();
}
{code}

This is not the correct way to convert primitives to their object equivalents.

((Integer) x).hashCode() == x
Boolean#hashCode() is defined as

value ? 1231 : 1237

Note that this error won't be found unless the compiler emits warnings for 
boxing.
            Reporter: Sebb




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to