[
https://issues.apache.org/jira/browse/SANDBOX-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291744#comment-13291744
]
Simone Tripodi edited comment on SANDBOX-399 at 6/8/12 12:39 PM:
-----------------------------------------------------------------
Interesting approach, I like it! few observations that I am going to apply
before resolving the issue:
* {{DefaultArgumentsAccessor#withArguments()}} contains an unnecessary
{{else}} branch, it can be omitted;
* {{NullBeanAccessor}} can be final;
* instead of creating the {{NullBeanAccessor}} error message each time, it can
be a final field of the class;
* {{NullBeanAccessor#cast()}} can return null, {{(String) null}} is something
devs are used to;
* {{copyPropertiesTo(T)}}, {{describe()}} and {{populate(Map)}} should throw
NPE - it is IMHO a matter of coherence - what's your opinion on that, since you
marked the TODOs?
was (Author: simone.tripodi):
Interesting approach, I like it! few observations that I am going to apply
before resolving the issue:
* {{NullBeanAccessor}} can be final;
* instead of creating the {{NullBeanAccessor}} error message each time, it can
be a final field of the class;
* {{NullBeanAccessor#cast()}} can return null, {{(String) null}} is something
devs are used to;
* {{copyPropertiesTo(T)}}, {{describe()}} and {{populate(Map)}} should throw
NPE - it is IMHO a matter of coherence - what's your opinion on that, since you
marked the TODOs?
> [BeanUtils2] Handle methods that return void separatly
> ------------------------------------------------------
>
> Key: SANDBOX-399
> URL: https://issues.apache.org/jira/browse/SANDBOX-399
> Project: Commons Sandbox
> Issue Type: Improvement
> Components: BeanUtils2
> Affects Versions: Nightly Builds
> Reporter: Benedikt Ritter
> Attachments: SANDBOX-399.txt
>
>
> Since {{ArgumentsAccessor.withArguments(...)}} returns a new {{BeanAccessor}}
> problems occur if a method's return type is void. To deal with this a Special
> Case implementation of BeanAccessor should be invented.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
