[
https://issues.apache.org/jira/browse/SANDBOX-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293876#comment-13293876
]
Simone Tripodi commented on SANDBOX-397:
----------------------------------------
guten abend Bene,
{quote}
Usually I try to avoid long return statements like the ones introduced through
{{checkMethod}} in {{DefaultBeanProperties}}. To much inlining can be very
confusing. However, since there isn't to much logic in those methods, I guess
we can leave it as it is.
{quote}
I am not sure I understood what you are referring -
{{DefaultBeanProperties#checkMethod()}} is similar to
{{Assertions#checkNotNull}} but they throw different exceptions...
{quote}
You should have a look at the extracted {{BeanProperties}} interface. I guess
your IDE refactoring created some public modifiers and some abstract method
declarations, that we can get rid of.
{quote}
hehehe yup perfectly right - I have been too lazy this time, thanks for
pointing!
{quote}
I'm not happy about those methods in {{BeanProperties}} either, but at the time
I didn't have a better solution. Feel free to change what ever you like (like
you already did ;) )
{quote}
nice to hear we found anyway an agreement!!
looking forward to apply more patches from you, alles gute!
> [BeanUtils2] Replace NullPointerExceptions been thrown in DefaultBeanAccessor
> with NoSuchMethodEceptions
> --------------------------------------------------------------------------------------------------------
>
> Key: SANDBOX-397
> URL: https://issues.apache.org/jira/browse/SANDBOX-397
> Project: Commons Sandbox
> Issue Type: Task
> Components: BeanUtils2
> Affects Versions: Nightly Builds
> Reporter: Benedikt Ritter
> Assignee: Simone Tripodi
> Attachments: SANDBOX-397.txt, SANDBOX-397_SRP.txt,
> SANDBOX-397_SRPv2.txt
>
>
> At the moment, methods in {{DefaultBeanAccessor}} throw a
> {{NullPointerException}}, if no {{PropertyDescriptor}} for a given property
> name can be retrieved. As discussed on the ML (see
> http://markmail.org/thread/zlehclmybp5xgn5n) this behavior should be changed
> to throwing {{NoSuchMethodException}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
