[ 
https://issues.apache.org/jira/browse/VFS-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402280#comment-13402280
 ] 

Gary D. Gregory commented on VFS-405:
-------------------------------------

Hi Benjamin,

Your 0002 patch is the kind of functionality I was thinking about. Thank you 
for that :)

Some requests though:

- Please provide unit tests for new the APIs.
- Wrong message keys. For example, the AFO.setExecutable implementation refers 
to the wrong message key in the FSException message. You need to create a new 
message and key for all the new setter APIs. See Resources.properties. 
- OnCallRefreshFileObject needs the new APIs.
- DelegateFileObject needs the new APIs.
- In genenral, look for the current implementers of a similar API to find 
missing spots. Eclipse is quite good for that, for example look at all the 
implementors of FO.isExecutable.

As an example to get started, update to trunk what I just did for 
https://issues.apache.org/jira/browse/VFS-425


                
> Get/set the file permissions
> ----------------------------
>
>                 Key: VFS-405
>                 URL: https://issues.apache.org/jira/browse/VFS-405
>             Project: Commons VFS
>          Issue Type: Improvement
>            Reporter: Damian Waszak
>         Attachments: permissions-0001.patch, permissions-0002.patch
>
>
> Add possibility to change file permissions through VFS, similar to executing 
> *chmod* command on a file.
> Simple use case scenario would be to move a file to SFTP server, and then 
> retrieve and change the permissions, e.g. exececute chmod 0644.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to