[ 
https://issues.apache.org/jira/browse/NET-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406450#comment-13406450
 ] 

Gary D. Gregory commented on NET-468:
-------------------------------------

Hello,

I cannot apply the patch. Did you use SVN diff to create the patch?

The format looks odd:

I see:
{noformat}
--- src/main/java/org/apache/commons/net/SocketClient.java      2012-04-24 
17:30:45.596176007 +0200
+++ ../../org/apache/commons/net/SocketClient.java      2012-07-02 
18:21:00.287784277 +0200
...
{noformat}

and expect:
{noformat}
Index: src/main/java/org/apache/commons/net/SocketClient.java
===================================================================
--- src/main/java/org/apache/commons/net/SocketClient.java      (revision 
1357226)
+++ src/main/java/org/apache/commons/net/SocketClient.java      (working copy)
...
{noformat}


Thank you,
Gary
                
> Request for native support for socks proxy routing with Commons net FTP
> -----------------------------------------------------------------------
>
>                 Key: NET-468
>                 URL: https://issues.apache.org/jira/browse/NET-468
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: FTP
>    Affects Versions: 1.4, 2.0, 3.0.1, 3.1
>         Environment: We use commons net  in out products for all 
> communication to an FTP server. OS : All. No other environment specifications.
>            Reporter: Ramya Rajendiran
>         Attachments: sockclient-proxy2.diff
>
>
> Commons net currently does not natively support connection to an FTP server 
> via a socks proxy. The only way of achieving this would be to work at the 
> socket level as observed here 
> http://wiki.apache.org/commons/Net/FrequentlyAskedQuestions. (by setting JVM 
> properties socksProxyPort and socksProxyPortHost)
> However, a major side effect of this all connections on this JVM will go 
> through the socks proxy since this setting is at the JVM level. This is 
> sometimes undesirable as the business requirements are such that only certain 
> applications on the JVM need to go through the socks proxy. There are no 
> existing workarounds to conditionally prevent other applications to not be 
> routed through the socks proxy. This makes our application which consumes the 
> commons net unusable for such businesses.
> Providing native support for socks proxy with commons net for FTP, will go a 
> long way in supporting such common scenarios and business continuity. 
> Therefore raising this enhancement request. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to