[
https://issues.apache.org/jira/browse/SANDBOX-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420591#comment-13420591
]
Simone Tripodi commented on SANDBOX-419:
----------------------------------------
I applied the patch - wich is quiet good - see revision 1364590 - and let it
open to address some TODOs.
{quote}
can we be sure that the first parameter type always will be of type int and the
second parameter type will be the type of the indexed property?
{quote}
uhm don't think so...
{quote}
if so do we have to check if the first parameter is really of type int or do we
only have to check if the second parameter type is assignment compatible to
value?
{quote}
that would be better option, IMHO
Few minor observations about applied patch:
* {{IndexedPropertySetter}} was good but thought
{{DefaultIndexedPropertySetter}} would be more canonical according to
interfaces/implementations "conventions" we adopted;
* {{o.a.c.bu2.internal}} package doesn't exist anymore, I adapted the code -
maybe your local copy was not properly up-to-date;
* trivial code format - no worries, already fixed.
Looking forward the next patch to mark this issue as _resolved_
TIA!
> [BeanUtils2] Implement setIndexed(String propertyName) on DefaultBeanAccessor
> -----------------------------------------------------------------------------
>
> Key: SANDBOX-419
> URL: https://issues.apache.org/jira/browse/SANDBOX-419
> Project: Commons Sandbox
> Issue Type: Improvement
> Components: BeanUtils2
> Affects Versions: Nightly Builds
> Reporter: Benedikt Ritter
> Attachments: SANDBOX-419.patch
>
>
> Implement {{DefaultBeanAccessor.setIndexed(String propertyName)}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
