[
https://issues.apache.org/jira/browse/FUNCTOR-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421849#comment-13421849
]
Bruno P. Kinoshita commented on FUNCTOR-12:
-------------------------------------------
Author: kinow
Date: Tue Jul 24 22:34:23 2012
New Revision: 1365329
URL: http://svn.apache.org/viewvc?rev=1365329&view=rev
Log:
[FUNCTOR-12] Added more tests to core composite classes. Also removed
unreachable code, as it could not be tested and was immutable and
created/validated during construction. Tests that were using a try/catch +
fail() approach were updated to use @Test(expected=SomeClass.class). There was
one class with tests in JUnit 3 format that weren't being executed by JUnit 4,
it was corrected by adding @Test to its methods. And new classes were added for
classes not covered (the license header was copied from other classes).
Added:
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestTransformedBinaryFunction.java
(with props)
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestTransformedBinaryProcedure.java
(with props)
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestTransformedFunction.java
(with props)
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestTransformedProcedure.java
(with props)
Modified:
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/AbstractLoopProcedure.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/BaseBinaryPredicateList.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/BasePredicateList.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/BaseUnaryPredicateList.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/BinaryNot.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/Composite.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/CompositeUnaryFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/ConditionalBinaryFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/ConditionalBinaryPredicate.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/ConditionalBinaryProcedure.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/ConditionalFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/ConditionalPredicate.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/ConditionalProcedure.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/ConditionalUnaryFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/ConditionalUnaryPredicate.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/ConditionalUnaryProcedure.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/Not.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/Sequence.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/TransformedBinaryFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/TransformedBinaryProcedure.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/TransformedFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/TransformedProcedure.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/TransposedFunction.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/TransposedPredicate.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/TransposedProcedure.java
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/UnaryNot.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestAbstractLoopProcedure.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestAnd.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestBinaryAnd.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestBinaryCompositeBinaryFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestBinaryNot.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestBinaryOr.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestBinarySequence.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestComposite.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestCompositeUnaryFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestCompositeUnaryPredicate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestCompositeUnaryProcedure.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestConditional.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestConditionalBinaryFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestConditionalBinaryPredicate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestConditionalBinaryProcedure.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestConditionalFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestConditionalPredicate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestConditionalProcedure.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestConditionalUnaryFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestConditionalUnaryPredicate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestConditionalUnaryProcedure.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestNot.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestOr.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestSequence.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestTransposedFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestTransposedPredicate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestTransposedProcedure.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestUnaryAnd.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestUnaryCompositeBinaryFunction.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestUnaryCompositeBinaryPredicate.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestUnaryNot.java
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/composite/TestUnaryOr.java
> improve test coverage
> ---------------------
>
> Key: FUNCTOR-12
> URL: https://issues.apache.org/jira/browse/FUNCTOR-12
> Project: Commons Functor
> Issue Type: Improvement
> Reporter: Emmanuel Bourg
> Assignee: Bruno P. Kinoshita
>
> Specifically the composite package contains untested classes, per
> http://markmail.org/message/ythw55yad5lrvqrj
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
