[
https://issues.apache.org/jira/browse/POOL-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425341#comment-13425341
]
Liviu Tudor commented on POOL-225:
----------------------------------
I have initially tried to remove the warning for
{{org.apache.commons.pool.impl.GenericObjectPool$Evictor}} -- problem is that
is a private class and as such FindBugs doesn't seem to find it properly -- in
fact the warning is against the {{GenericObjectPool}} class rather than evictor
too!
I've looked through the FindBugs docco but couldn't find a way around it hence
the pattern to apply it to the class itself.
Incidently trying to apply it to the method {{run}} fails, since the method
{{run}} doesn't belong to the class -- so a bit of a FindBugs odditty. Would
love some ideas around it if this is not a good way to go about it?
> Changes to findbugs-exclude-filter.xml to eliminate false alerts on Evictor
> classes
> -----------------------------------------------------------------------------------
>
> Key: POOL-225
> URL: https://issues.apache.org/jira/browse/POOL-225
> Project: Commons Pool
> Issue Type: Improvement
> Affects Versions: 1.6
> Reporter: Liviu Tudor
> Priority: Trivial
> Labels: findbugs
> Fix For: 1.6.1
>
> Attachments: POOL-225.2.patch, POOL-225.patch.bz2
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> For both {{GenericKeyedObjectPool}} and {{GenericObjectPool}}, FindBugs
> signals an inconsistent sycnhronization warning ({{IS2_INCONSISTENT_SYNC}})
> however it turns out it's a false alert.
> Talking to [pool] developers, the general consensus was to update
> {{findbugs-exclude-filter.xml}} to exclude these 2 checks, hence this ticket.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
