[ 
https://issues.apache.org/jira/browse/MATH-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427691#comment-13427691
 ] 

Phil Steitz commented on MATH-834:
----------------------------------

Are these changes really necessary?  RandomData instances can be convenient. I 
was OK moving the implementations of the actual sampling methods to the 
distributions, but I see no reason that we should not keep RandomData as a 
means of generating random data from multiple different distributions.  It is 
easier to just import one class and use nextXxx methods directly than to import 
and instantiate multiple distribution classes in use cases (e.g. 
AggregateSummaryStatisticsTest) where random data from different distributions 
are generated.
                
> Replace calls to the various sampling methods in "RandomDataImpl"
> -----------------------------------------------------------------
>
>                 Key: MATH-834
>                 URL: https://issues.apache.org/jira/browse/MATH-834
>             Project: Commons Math
>          Issue Type: Task
>            Reporter: Gilles
>            Assignee: Gilles
>            Priority: Minor
>             Fix For: 3.1
>
>
> Following MATH-764 and MATH-823, the "authoritative" code that implements 
> sampling from distributions is located in the class that represents a 
> specific distribution (in package "o.a.c.m.distribution").
> Hence, all CM code that performs sampling from a distribution should call the 
> "sample" method from the corresponding distribution, instead of one of the 
> methods defined in "RandomDataImpl" (in package "o.a.c.m.random").

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to