[ 
https://issues.apache.org/jira/browse/MATH-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428634#comment-13428634
 ] 

Gilles commented on MATH-610:
-----------------------------

bq. [...] the patch looks ok,

It's not; but easy to fix manually ("math" vs "math3").

                
> [patch] objects that use compareTo should have equals as well
> -------------------------------------------------------------
>
>                 Key: MATH-610
>                 URL: https://issues.apache.org/jira/browse/MATH-610
>             Project: Commons Math
>          Issue Type: Improvement
>            Reporter: Dave Brosius
>            Priority: Trivial
>             Fix For: 3.1
>
>         Attachments: equals.diff
>
>
> NaturalRanking implements compareTo. Code that implements compareTo should 
> also implement equals, and those that implement equals should implement 
> hashCode. This patch does this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to