[
https://issues.apache.org/jira/browse/NET-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ketan reopened NET-426:
-----------------------
the _prepareDataSocket_ method doesn't work for retrieving and storing file
since these methods call
org.apache.commons.net.ftp.FTPClient._openDataConnection_(String, String)
method, which does not call _prepareDataSocket_ method.
Can we get this fixed? Without this you still get errors.
Here are the methods that are calling
org.apache.commons.net.ftp.FTPClient._openDataConnection_(String, String)
org.apache.commons.net.ftp - commons-net.jar
_openDataConnection_(int, String)
_retrieveFile(String, String, OutputStream)
_retrieveFileStream(String, String)
_storeFile(String, String, InputStream)
_storeFileStream(String, String)
> FTPS: Hook to customize _openDataConnection_ SSLSocket before
> startHandshake() is called
> ----------------------------------------------------------------------------------------
>
> Key: NET-426
> URL: https://issues.apache.org/jira/browse/NET-426
> Project: Commons Net
> Issue Type: Bug
> Components: FTP
> Affects Versions: 3.0.1
> Reporter: Ketan
> Priority: Critical
> Fix For: 3.1
>
> Attachments: FTPSClient.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Currently in FTPSClient class, there is protected _openDataConnection_
> method, which create SSLSocket for data connection. But there is no hook to
> customize the SSLSocket before startHandshake is called.
> I need to know the remote host ip and port, which i can get for socket, and
> do custom setup to try to reuse SSL sessions from control connection socket.
> Since the socket factory uses createSocket() method, I can't just use custom
> socket factory since I don't know the host and port. I can't just override
> the _openDataConnection_() method in my class since that will call the
> startHandshake().
> So it would be nice if you can provide hook, much like _connectAction_(), but
> for data connection before handshake is started. You can pass the new data
> socket as argument to this hook method so one can get remote host and port
> information.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
