[ 
https://issues.apache.org/jira/browse/IO-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429990#comment-13429990
 ] 

Joerg Schaible commented on IO-341:
-----------------------------------

Sorry, but no, this is not how it works. A patch may not include arbitrary 
other stuff, I cannot see, how this charset in the patch stuff is related here.

Additionally I don't understand your constant. You introduce a constant named 
'CHAR' that contains the byte sequence in UTF-16BE (native Java 
representation). The name of the constant does not reflect its purpose and  I 
cannot see how it is useful especially for readers. If a file contains a BOM, 
it can be any of those byte sequences that are handled by the ByteOrderMark 
class. 
                
> A constant for holding the BOM character (U+FEFF) 
> --------------------------------------------------
>
>                 Key: IO-341
>                 URL: https://issues.apache.org/jira/browse/IO-341
>             Project: Commons IO
>          Issue Type: Improvement
>          Components: Streams/Writers
>            Reporter: Yaniv Kunda
>            Priority: Minor
>         Attachments: ByteOrderMark.patch
>
>
> This can be useful when working with readers/writers -
> can be put as a constant in ByteOrderMark, for example.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to