[ 
https://issues.apache.org/jira/browse/MATH-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434580#comment-13434580
 ] 

Gilles commented on MATH-845:
-----------------------------

bq. I have modified my local copy of pom.xml [...]

That should not be necessary, the "pom.xml" in "trunk" already contains the 
necessary configuration.

But I'm not sure that those formatting rules which I referred to above are 
enforced by CheckStyle. I just did a manual detection! ;)

bq. About "assert" [...]

This an interesting question. Maybe you should raise the issue on the "dev" ML.
AFAIK, there is no policy for the use of "assert" within the CM code.
In the case of a library like CM, robustness is important; I guess that it is 
less safe to use "assert" since an application could silently fail if 
assertions are not enabled.
In cases where the method is for internal use only, and we are sure that the CM 
code calls it correctly, my preference would be to just remove the unused 
statement, and replace it with an appropriate comment stating why an explicit 
check is not necessary.

                
> Basic number theory features such as primality testing, factorization and 
> prime number generation
> -------------------------------------------------------------------------------------------------
>
>                 Key: MATH-845
>                 URL: https://issues.apache.org/jira/browse/MATH-845
>             Project: Commons Math
>          Issue Type: New Feature
>    Affects Versions: 3.1
>         Environment: ubuntu/java6/intel-i5
>            Reporter: Sebastien Riou
>            Priority: Minor
>              Labels: features
>             Fix For: 3.1
>
>         Attachments: primes-src.zip
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> A set of static methods to perform primality test, factorization and prime 
> number generation. Currently it is limited to the int data type, extension to 
> long/BigInteger will follow.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to