[ 
https://issues.apache.org/jira/browse/MATH-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460536#comment-13460536
 ] 

Luc Maisonobe commented on MATH-863:
------------------------------------

I think we are drifting away from the original goal to have a Quaternion 
class...

If this class cannot implement Field because of commutativity problems, then 
don't implement the interface.
For now, there is no use of non-commutative Field. Sébastien already pointed 
out his Polynomial implementation would fail with them, and there is a high 
risk LUDecompistion would also fail.

I would suggest to just do a quick test on LUDecomposition and if as expected 
it fails then drop the idea entirely. Implementing the interface is not for the 
pure mathematical elegance, we do it only if it serves some purpose.
                
> new Quaternion class added in complex package
> ---------------------------------------------
>
>                 Key: MATH-863
>                 URL: https://issues.apache.org/jira/browse/MATH-863
>             Project: Commons Math
>          Issue Type: New Feature
>    Affects Versions: 3.1
>            Reporter: Julien Anxionnat
>         Attachments: quaternion_adjustments.patch, quaternion.patch, 
> quaternion_v2.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> This patch provides a new class for the mathematical object "Quaternion" in 
> the complex package.
> This quaternion is considered as a mathematical object (the Hamilton's 
> hypercomplex number).
> Note that it's not a rotation quaternion which has to be a quaternion of norm 
> one. Although this feature could be used for a getter in the Rotation class.
> This patch provides also some improvements in Precision class : a "double 
> comparison epsilon" and a method to compute relative comparison.
> (Please, note that's it's my first contribution, and I apologize in advance 
> for my mistakes…) 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to