[
https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466482#comment-13466482
]
Luc Maisonobe commented on MATH-811:
------------------------------------
I looked at the patch.
It seems to work, but I am still not sure. The provided patch still contains
both formatting changes (lines wrapping, removed spaces...) and the feature
changes themselves. As it also introduces structural changes with an upper
level if/then/else clause, it is almmost impossible to read.
Nevertheless, the most important thing is that this patch has to wait for 4.0,
it cannot be committed in 3.1. It introduces an incompatible source and binary
change in a core user interface: EventHandler. This insterface is a very
important pure user interface in the ODE package. Many users implement it and
would be affected by this change. Note also that as this is a pure user
interface with no implementations provided by Apache Commons Math, it cannot be
changed to an abstract class for future versions either, as some interfaces
have been changed for 3.0.
> Improve event detection by selecting g function slope
> -----------------------------------------------------
>
> Key: MATH-811
> URL: https://issues.apache.org/jira/browse/MATH-811
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.1
> Reporter: Yannick TANGUY
> Attachments: JIRA-811_slope_selection.patch,
> JIRA-811_slope_selection_V2.patch, JIRA-811_slope_selection_V3.patch,
> JIRA-811_slope_selection_V3_with_spaces.patch,
> JIRA-811_slope_selection_with_spaces.patch
>
>
> We would like to select g function slope in CommonsMath event detection
> feature.
> This would improve event detection for the final user (the possibility to
> ignore some events, and less computation time) and also correct a bug found
> while using OREKIT (see https://www.orekit.org/forge/issues/104) in our
> applications.
> The modification consists in adding a method (getSlopeSelection() : int) in
> EventHandler, and modifying one conditionnal in the method evaluateStep
> (class EventState).
> We can provide modified code and unitary tests for this feature.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
