[
https://issues.apache.org/jira/browse/MATH-816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jared Becksfort updated MATH-816:
---------------------------------
Attachment: MixtureMultivariateRealDistributionTest.java
MixtureMultivariateRealDistribution.java.patch
Gilles,
I am attaching a patch for MixtureMultivariateRealDistribution class that
removes the temporary code and comments.
I am including the plain java file for the test because it was renamed. Running
a rename and patch on my end basically just generated a patch containing the
entire file. The new test file uses the generic code and the modified component
seed method. I added one precondition test for dimension checking and removed
the one that checked for the weight sum to equal one because your previous
changes made it unnecessary.
Please let me know if you need anything else from me for this issue to be
resolved.
Jared
> Multivariate Normal Mixture Models
> ----------------------------------
>
> Key: MATH-816
> URL: https://issues.apache.org/jira/browse/MATH-816
> Project: Commons Math
> Issue Type: New Feature
> Reporter: Jared Becksfort
> Priority: Minor
> Fix For: 3.2
>
> Attachments: MixtureMultivariateRealDistribution.java,
> MixtureMultivariateRealDistribution.java,
> MixtureMultivariateRealDistribution.java.patch,
> MixtureMultivariateRealDistributionTest.java,
> MultivariateNormalMixtureModelDistribution.java,
> MultivariateNormalMixtureModelDistributionTest.java
>
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> I will submit a class for Multivariate Normal Mixture Models. Not sure it
> will allow sampling initially.
> > Hello,
> >
> > I have implemented some classes for multivariate Normal distributions,
> > multivariate normal mixture models, and an expectation maximization fitting
> > class for the mixture model. I would like to submit it to Apache Commons
> > Math. I still have some touching up to do so that they fit the style
> > guidelines and implement the correct interfaces. Before I do so, I thought
> > I would at least ask if the developers of the project are interested in me
> > submitting them.
> >
> > Thanks,
> > Jared Becksfort
> Dear Jared,
> Yes, that would be very nice to have such an addition! Remember to also
> include unit tests (refer to the current ones for examples). The best would
> be to split a submission up into multiple minor ones, each covering a natural
> submission (e.g. multivariate Normal distribution in one submission), and
> create an issue as described at
> http://commons.apache.org/math/issue-tracking.html .
> If you run into any problems, please do not hesitate to ask on this mailing
> list.
> Cheers, Mikkel.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
